Modified surface_ice.py to change near_infrared surface albedo as wel…#122
Open
edmundderby wants to merge 1 commit intoCliMT:developfrom
Open
Modified surface_ice.py to change near_infrared surface albedo as wel…#122edmundderby wants to merge 1 commit intoCliMT:developfrom
edmundderby wants to merge 1 commit intoCliMT:developfrom
Conversation
…l as shortwave surface albedo. near_infrared values were set to same values as existing shortwave values
JoyMonteiro
requested changes
Jul 21, 2020
Member
JoyMonteiro
left a comment
JoyMonteiro
left a comment
There was a problem hiding this comment.
Hello Edmund,
sorry for the huge turnaround time. I'm fine with the changes, they look good!
A couple of things that are needed:
- Update HISTORY.rst to reflect these changes
- Update AUTHORS.rst and add your name to it
- Delete the cached test output for the SurfaceIce component in https://github.com/CliMT/climt/tree/develop/tests/cached_component_output and regenerate new files by running the tests on your machine. This will ensure your PR will pass the tests.
Author
|
Thanks Joy. I'm having a bit of trouble following the instructions for running the tests, but once I've figured them out I'll resubmit |
Member
|
Great! Let me know if I can help in any way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l as shortwave surface albedo. near_infrared values were set to same values as existing shortwave values